Fix an issue in PartitionGatherTrivialSlicedOperandDimensions when handling out-of-bound indices.
#20401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_704842079
branch
3 times, most recently
from
dfc2f90 to
0dda26d
Compare
…handling out-of-bound indices. A gather operation will clamp the fetched indices such that we always retrieve the corresponding entries in the operand. However, the result of `PartitionGatherTrivialSlicedOperandDimensions` will do not handle these indices. Namely, if the indices is out of bound, we do not retrieve the entries from the operand and the result is 0. This is a execution bug in SPMD partitioner in both GSPMD and Shardy. The compilation succeeds. This issue does not exist in scatter since scatter does not need to clamp the indices. This change fixes this issue by clamping the indices at the very beginning of `PartitionGatherTrivialSlicedOperandDimensions`. PiperOrigin-RevId: 705678305
copybara-service
bot
force-pushed
the
test_704842079
branch
from
0dda26d to
a803260
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix an issue in
PartitionGatherTrivialSlicedOperandDimensionswhen handling out-of-bound indices.A gather operation will clamp the fetched indices such that we always retrieve the corresponding entries in the operand. However, the result of
PartitionGatherTrivialSlicedOperandDimensionswill do not handle these indices. Namely, if the indices is out of bound, we do not retrieve the entries from the operand and the result is 0.This is a execution bug in SPMD partitioner in both GSPMD and Shardy. The compilation succeeds. This issue does not exist in scatter since scatter does not need to clamp the indices.
This change fixes this issue by clamping the indices at the very beginning of
PartitionGatherTrivialSlicedOperandDimensions.